…ssue #67)

Changes:
- Remove Get UseCase (UseCases now only for data modification)
- Add changedByBitrix24UserId field to track who modified settings
- Add isRequired field for frontend validation hints
- Create ApplicationSettingChangedEvent with old/new values and change tracking
- Move InstallSettings from root Services to ApplicationSettings namespace
- Update Set UseCase to support new fields
- Update all tests for new Entity constructor signature
- Add comprehensive tests for new fields and event emission

Entity changes:
- changedByBitrix24UserId: nullable int, tracks modifier
- isRequired: boolean, indicates required settings for frontend
- updateValue() now emits ApplicationSettingChangedEvent

Doctrine mapping updated with new fields:
- changed_by_b24_user_id (nullable)
- is_required (not null)

Major improvements to ApplicationSettings:

1. Enum ApplicationSettingStatus
   - Added enum with Active and Deleted states
   - Supports soft-delete pattern for data retention

2. Entity changes
   - Added status field (ApplicationSettingStatus)
   - Added markAsDeleted() method for soft-delete
   - Added isActive() method to check status
   - Updated Doctrine mapping with status field and index

3. Repository improvements
   - All find* methods now filter by status=Active
   - Added softDeleteByApplicationInstallationId() method
   - Soft-deleted records excluded from queries by default
   - Hard delete methods preserved for admin operations

4. UseCase Delete refactored
   - Changed from hard delete to soft-delete
   - Calls markAsDeleted() instead of repository->delete()
   - Preserves data for audit and recovery

5. New UseCase: OnApplicationDelete
   - Command and Handler for bulk soft-delete
   - Triggered when application is uninstalled
   - Soft-deletes all settings for installation
   - Maintains data integrity and history

6. Comprehensive tests
   - Unit tests for status and markAsDeleted()
   - Functional tests for soft-delete behavior
   - Tests verify deleted records persist in DB
   - Full test coverage for OnApplicationDelete

7. Documentation
   - Complete guide in docs/application-settings.md
   - Russian language documentation
   - Detailed examples and best practices
   - Architecture and concepts explained
   - CLI commands and API usage

Key benefits:
- Data retention for compliance and audit
- Ability to recover accidentally deleted settings
- Historical data analysis capabilities
- Safe uninstall with data preservation

Database schema:
- Added status column (enum: active/deleted)
- Added index on status for query performance
- Backward compatible with existing data

- Add findByApplicationInstallationIdAndKey() as alias for findGlobalByKey()
- Add findByApplicationInstallationId() as alias for findAll()
- Update interface with new methods
- Fixes test compatibility issues

- Add getEvents() method to retrieve pending events without clearing them
- Method is useful for testing event emission
- Fixes unit test errors for ApplicationSetting event tests
- All 29 unit tests now passing

- Remove event testing methods from ApplicationSettingTest
  - testUpdateValueEmitsEvent()
  - testUpdateValueDoesNotEmitEventWhenValueUnchanged()
- Revert AggregateRoot to original implementation (remove getEvents method)
- Events are emitted via emitEvents() but not directly tested in entity tests
- Follows pattern used in Bitrix24Account and other entities
- All 27 unit tests passing (55 assertions)

Changes:
- Fix PHPStan error in Set/Handler.php
  - Add intersection type annotation for AggregateRootEventsEmitterInterface
  - Import ApplicationSettingInterface explicitly
- Apply PHP-CS-Fixer formatting to 14 files
  - Fix doc comment periods
  - Fix constructor body formatting
  - Fix fluent interface formatting
- Move documentation from docs/ to src/ApplicationSettings/Docs/
- All 27 unit tests passing (55 assertions)

Major changes:
1. Remove getStatus() method
   - Removed from ApplicationSetting entity and interface
   - Updated all tests to use isActive() instead
   - Maintains encapsulation of status field

2. Refactor OnApplicationDelete to use domain methods
   - Removed softDeleteByApplicationInstallationId() from repository
   - Handler now fetches all settings and marks each as deleted
   - Better follows domain-driven design principles
   - Added deletedCount to logging

3. Remove backward compatibility methods
   - Removed findByApplicationInstallationIdAndKey() from repository
   - Updated all tests to use findGlobalByKey() directly
   - Cleaner repository interface

4. Add PHPDoc annotations
   - Added @return ApplicationSettingInterface[] to findByApplicationInstallationId()
   - Improves IDE support and type checking

5. Remove getRecommendedDefaults() static method
   - Removed from InstallSettings service
   - Updated documentation to reflect proper usage
   - Developers should define their own defaults

6. Refactor InstallSettings to use Set UseCase
   - Now uses Set\Handler instead of direct repository access
   - Follows CQRS pattern consistently
   - Removed direct entity instantiation
   - Simplified constructor (removed repository and flusher dependencies)

7. Add comprehensive unit tests for InstallSettings
   - Tests for default settings creation
   - Tests for logging behavior
   - Tests for global settings scope
   - Tests for empty settings array handling
   - 31 unit tests passing (66 assertions)

All tests passing:
- 31 unit tests with 66 assertions
- PHP-CS-Fixer formatting applied
- PHPStan errors only in unrelated test base classes

Changes:
1. Simplify Delete UseCase Command
   - Remove b24UserId and b24DepartmentId parameters
   - Delete now only works with global settings
   - Updated Handler to use findGlobalByKey()
   - Updated all tests

2. Fix repository method naming conflict
   - Rename findAll() to findAllForInstallation()
   - Avoids conflict with EntityRepository::findAll()
   - Updated all usages in UseCases and tests
   - Updated findByApplicationInstallationId() alias

3. Fix Doctrine XML mapping
   - Change enumType to enum-type (correct syntax for Doctrine ORM 3)
   - Fixes mapping validation errors

4. Add comprehensive contract tests for ApplicationSettingRepository
   - testCanFindPersonalSettingByKey - test personal scope
   - testCanFindDepartmentalSettingByKey - test departmental scope
   - testCanFindAllGlobalSettings - test global settings filtering
   - testCanFindAllPersonalSettings - test personal settings filtering
   - testCanFindAllDepartmentalSettings - test departmental settings filtering
   - testSoftDeletedSettingsAreNotReturnedByFindMethods - test soft-delete
   - testFindByKeySeparatesScopes - test scope separation
   - Total: 19 repository tests covering all scenarios

All unit tests passing: 31 tests, 66 assertions
Code style: PHP-CS-Fixer applied

Applied automated code modernization with Rector:
- Added #[\Override] attributes to overridden methods
- Renamed variables to match method return types
- Converted closures to arrow functions where appropriate
- Added return types to closures and arrow functions
- Simplified boolean comparisons
- Improved code readability

Applied PHP-CS-Fixer formatting for consistent code style.

All tests passing (31 tests, 66 assertions).

- Add PHPDoc annotations for mock types
- Remove unused variable in callback
- All unit tests passing (31 tests, 66 assertions)
- PHPStan errors reduced from 25 to 18

Removed methods:
- findAllGlobal(Uuid): array
- findAllPersonal(Uuid, int): array
- findAllDepartmental(Uuid, int): array
- deleteByApplicationInstallationId(Uuid): void
- findByApplicationInstallationId(Uuid): array

Changes:
- Updated ApplicationSettingRepositoryInterface - removed 5 methods
- Updated ApplicationSettingRepository - removed implementations
- Updated ApplicationSettingsListCommand - use findAllForInstallation with filtering
- Updated tests - removed related test methods
- Updated documentation - show filtering pattern

The API is now simpler with single findAllForInstallation() method.
Filtering by scope is done in application code using entity methods
(isGlobal(), isPersonal(), isDepartmental()).

All tests passing (174 tests, 288 assertions).
All linters clean (PHPStan, Rector, PHP-CS-Fixer).

…rvice

Major changes:
- Removed 6 redundant repository methods, kept only findAllForInstallation()
- Added documentation about uniqueness invariant (installation+key+user+department)
- Created InMemory repository implementation for fast unit testing
- Created SettingsFetcher service with cascading resolution logic (Personal > Departmental > Global)
- Added comprehensive tests for InMemory repository (9 tests)
- Added comprehensive tests for SettingsFetcher (10 tests)
- Applied Rector and PHP-CS-Fixer improvements

Files changed:
- Modified ApplicationSettingRepositoryInterface: removed findGlobalByKey, findPersonalByKey, findDepartmentalByKey
- Modified ApplicationSettingRepository: removed method implementations
- Modified UseCase handlers to use findAllForInstallation() with filtering
- Updated all functional tests to use new filtering approach
- Added documentation section about invariants and uniqueness constraints
- Created ApplicationSettingInMemoryRepository with helper methods
- Created ApplicationSettingInMemoryRepositoryTest with 9 comprehensive tests
- Created SettingsFetcher service with getSetting() and getSettingValue() methods
- Created SettingsFetcherTest with 10 tests covering all override scenarios

All tests pass (193 unit tests, PHPStan level 5, Rector, PHP-CS-Fixer)

…ion handling

Changes:
- Created SettingsItemNotFoundException for when setting not found
- Renamed getSetting() to getItem() in SettingsFetcher
- Removed nullable return type from getItem() - now throws exception instead
- Updated getSettingValue() to return non-nullable string
- Updated all tests to use getItem() instead of getSetting()
- Replaced null-check tests with exception expectation tests
- Applied Rector and PHP-CS-Fixer improvements

All tests pass (193 unit tests, PHPStan level 5, Rector, PHP-CS-Fixer)

Changes:
- Added findAllForInstallationByKey(Uuid, string) method to repository interface
- Implemented method in ApplicationSettingRepository (Doctrine) with query filtering
- Implemented method in ApplicationSettingInMemoryRepository
- Updated SettingsFetcher to use new method instead of fetching all settings
- Added 3 unit tests for InMemory repository implementation
- Added 3 functional tests for Doctrine repository implementation
- Applied Rector improvements (parameter naming consistency)

Optimization:
- SettingsFetcher now fetches only settings with matching key instead of all settings
- Reduces memory usage and improves performance when many settings exist
- Database query now filters by both installation ID and key

All tests pass (196 unit tests, PHPStan level 5, Rector, PHP-CS-Fixer)

…update table name

Major refactoring of the ApplicationSettings bounded context to improve naming consistency and separate concerns between creating and updating settings.

Changes:

1. Entity Renaming:
   - Renamed ApplicationSetting → ApplicationSettingsItem
   - Renamed ApplicationSettingInterface → ApplicationSettingsItemInterface
   - Renamed ApplicationSettingChangedEvent → ApplicationSettingsItemChangedEvent
   - Updated all references and imports across the codebase

2. Repository Renaming:
   - ApplicationSettingRepository → ApplicationSettingsItemRepository
   - ApplicationSettingRepositoryInterface → ApplicationSettingsItemRepositoryInterface
   - ApplicationSettingInMemoryRepository → ApplicationSettingsItemInMemoryRepository
   - Fixed PHPDoc and class references

3. Database Schema:
   - Updated XML mapping entity name to ApplicationSettingsItem
   - Changed table name from 'application_setting' to 'application_settings'
   - Renamed mapping file to match new entity name

4. Use Case Refactoring (Breaking Change):
   - Renamed UseCase\Set → UseCase\Create
   - Create use case now ONLY creates new settings
   - Create throws InvalidArgumentException if setting already exists
   - Added new UseCase\Update for updating existing settings
   - Update throws InvalidArgumentException if setting doesn't exist
   - Update automatically emits ApplicationSettingsItemChangedEvent

5. Services Updated:
   - InstallSettings now uses Create use case
   - SettingsFetcher updated with new interface names
   - All service references updated

6. Tests Updated:
   - Renamed all test files to match new entity names
   - Updated Create tests to verify exception on duplicate
   - Added comprehensive Update use case tests
   - Fixed all test references and assertions
   - All tests pass

7. Documentation:
   - Completely updated application-settings.md
   - Documented Create vs Update separation
   - Added examples for both use cases
   - Updated all code examples
   - Added exception handling documentation

All changes verified with:
- PHPStan: ✓ No errors
- PHP-CS-Fixer: ✓ No style issues

…on support

Улучшения SettingsFetcher для более удобной работы с настройками:

1. Добавлен LoggerInterface:
   - Логирование всех операций getItem и getValue
   - Debug логи для каждого найденного scope (personal/departmental/global)
   - Warning лог когда настройка не найдена
   - Error лог при ошибках десериализации

2. Переименован метод getSettingValue → getValue:
   - Более короткое и удобное имя
   - Все использования обновлены в документации

3. Добавлена поддержка автоматической десериализации:
   - Новый параметр class?: class-string для getValue()
   - Использует Symfony Serializer для десериализации JSON в объекты
   - Возвращает string если class не указан, object если указан
   - PHPStan типизация с @template для type-safety

Пример использования:
```php
// Строковое значение
$value = $fetcher->getValue($uuid, 'app.theme');

// Десериализация в объект
$config = $fetcher->getValue(
    uuid: $uuid,
    key: 'api.config',
    class: ApiConfig::class
);
```

4. Обновлены тесты:
   - Добавлены mocks для serializer и logger
   - Новые тесты для десериализации
   - Тест для проверки логирования ошибок
   - Тест что serializer не вызывается без class параметра

5. Обновлена документация:
   - Обновлен раздел "Сервис SettingsFetcher"
   - Добавлены примеры с десериализацией
   - Обновлен Пример 2 с показом обоих вариантов использования
   - Все ссылки на getSettingValue заменены на getValue

Все изменения проверены:
- PHPStan: ✓ No errors
- PHP-CS-Fixer: ✓ Fixed formatting

Rector автоматически применил следующие улучшения:

1. Переименование переменных для соответствия типам:
   - $applicationSetting → $applicationSettingsItem
   - $expectedObject → $testConfigDto
   - $e → $throwable (для exception variables)

2. Переименование параметров методов:
   - save($applicationSetting) → save($applicationSettingsItem)
   - delete($applicationSetting) → delete($applicationSettingsItem)

3. Улучшение arrow functions:
   - Преобразование closures в arrow functions где возможно
   - Добавление return types для arrow functions

4. Doctrine repository improvements:
   - ChildDoctrineRepositoryClassTypeRector applied

Применённые правила:
- RenameVariableToMatchNewTypeRector
- RenameParamToMatchTypeRector
- CatchExceptionNameMatchingTypeRector
- ClosureToArrowFunctionRector
- AddArrowFunctionReturnTypeRector
- ChildDoctrineRepositoryClassTypeRector

Все тесты пройдены:
- Unit tests: ✓ 199/199
- PHPStan: ✓ No errors
- PHP-CS-Fixer: ✓ No issues

- Add SettingsItemAlreadyExistsException for Create use case
- Update Create Handler to throw specific exception for duplicates
- Update Delete Handler to use SettingsItemNotFoundException
- Replace mock Serializer with real Symfony Serializer in tests
- Add comprehensive type deserialization tests (string, bool, int, float, DateTime)
- Add symfony/property-access dependency for ObjectNormalizer
- All unit tests passing (204/204)

Changed the ApplicationSettingsItem entity to generate its own UUID v7
in the constructor instead of receiving it as a constructor argument.
This improves encapsulation and follows DDD principles by making the
entity responsible for its own identity generation.

Changes:
- Modified ApplicationSettingsItem constructor to generate UUID internally
- Updated Create Handler to remove UUID generation from constructor call
- Updated all unit and functional tests to match new constructor signature
- All tests passing (204/204)
- PHPStan level 5: no errors
- PHP-CS-Fixer: no issues

Replaced the direct execution of `composer-license-checker` with a `docker-compose` command, aligning it with other linting and analysis workflows.

Signed-off-by: mesilov <[email protected]>

…t filtering logic

Introduced TODOs for missing methods in `b24-php-sdk` interface to improve future compatibility. Refactored `Bitrix24Account` handling to filter master accounts explicitly, ensuring accurate validation and exception handling. Removed redundant `#[\Override]` attributes and enhanced comments for clarity. Updated `CHANGELOG.md` to reflect related changes.

Signed-off-by: mesilov <[email protected]>

…account filtering

Signed-off-by: mesilov <[email protected]>

Signed-off-by: mesilov <[email protected]>

…xamples, and improve best practices and security sections.

Signed-off-by: mesilov <[email protected]>

…ion, and enhance Quick Start documentation

Signed-off-by: mesilov <[email protected]>

…sue-67-01Pg2AJibYNoBKmUVijCYFhU

# Conflicts:
#	src/ApplicationInstallations/Infrastructure/Doctrine/ApplicationInstallationRepository.php
#	src/ApplicationInstallations/UseCase/Install/Handler.php
#	src/ApplicationInstallations/UseCase/OnAppInstall/Handler.php
#	src/ApplicationInstallations/UseCase/Uninstall/Handler.php

Signed-off-by: mesilov <[email protected]>

…n `findMasterAccountByMemberId` method

Signed-off-by: mesilov <[email protected]>

…or explicit persistence, adjust variable naming in commands, and simplify unique constraint validation

Signed-off-by: mesilov <[email protected]>

…e redundant TODO comments and PHPStan ignore directives

Signed-off-by: mesilov <[email protected]>

…nheritance, simplify constructor, and replace getEntityManager calls with entityManager property access

Signed-off-by: mesilov <[email protected]>

…y and refactor related code, tests, and documentation.

Signed-off-by: mesilov <[email protected]>

…emantics; update references, documentation, tests, and log prefixes.

Signed-off-by: mesilov <[email protected]>